03:30 <glogan> I never got that working. What I did instead was cheat and use the file copy steps to copy the key around, then clean up once I'm done using it.

03:32 <glogan> Well not native file copy, although that'd work too

03:32 <glogan> We use a central S3 based file store, so I've got a private bucket on that.

15:16 <razrdog[m]> That may be what I end up with. My goal is to end up using latent workers so I'd like to be able to pass the key through the git step.

15:16 <razrdog[m]> I'm reading through your template/master.cfg from the repo you sent above. It looks like your build factories are in a maintenance module. Is that where your s3 file copy steps occur or are you copying the files to the workers at deploy time somewhere in the ansible role?

16:45 <glogan> Credential copy and destroy happens on a per pipeline basis

16:45 <glogan> In part because the pipelines run in different environments and need different creds

16:45 <glogan> The builders and schedulers are in builders.py and schedulers.py

16:45 <glogan> Both are a huge mess, sorry haha

16:46 <glogan> Each pipeline is in a similarly named py file.

16:46 <glogan> If you can't find how something is done then it's probably in common.py. This is where the S3 related steps live, since they're common across pipelines.

16:49 <glogan> The whole ansible playbooks lives at https://github.com/opencast/opencast-project-infrastructure/tree/f/buildbot/ansible-buildbot-cluster

16:49 <glogan> There's an f/prod branch which is actually deployed to ci.opencast.org

16:55 <razrdog[m]> <glogan> "Both are a huge mess, sorry haha" <- It's been a huge help to read through whats happening on a larger project. I've got the basics but I'm learning a lot of options just reading your configs.

16:56 <glogan> Glad it's helping. That was my number one complaint with the docs - they're good but there's very few worked examples.

16:56 <glogan> Which, yeah yeah PRs welcome :)

17:01 <razrdog[m]> agreed on some of the docs. Maybe once I get a better feel for the codebase I'll make some PRs from my notes. I've got an update for the httpstatuspush planned currently. right now it expects a json body, I'd like it to send a plaintext body (of markdown) so that our matrix bot can post that into a CI room we have.

17:01 <razrdog[m]> The ssh-key issue is definitely still that there is something stripping the trailing newline from the end of the files during transfer.

17:41 <razrdog[m]> manually removing the strip option seems to break other secrets. there needs to be some sort of check to readd a newline to ssh-keys specifically

18:39 <glogan> Could you distribute/embed a read only ssh key safely?

21:19 <razrdog[m]> I can. But I also think the fix is easy enough. I'm working it now.

23:36 <razrdog[m]> I believe I've fixed the functionality and submitted a pull request at https://github.com/buildbot/buildbot/pull/6770

23:58 <glogan> Nice