09:50 <Guest40> hi everyone. I have trouble adding a hook from bitbucket to my buildbot installation. managed to get it working with github but i need to hook it to bitbucket. the error I get can be seen at https://pastebin.com/1cz9JCAQ - any ideas on how I should debug this? i'm at a loss and been banging my head for 2 days on it.

10:04 <cmouse> " builtins.KeyError: b'payload'"

10:04 <cmouse> it's not sending 'payload' in the request

10:13 <Guest40> cmouse  but that's a bitbucket issue, I guess, right?

10:14 <cmouse> or the api has changed

10:14 <cmouse> or you've misconfigured it

10:15 <Guest40> I'd rather it's a misconfiguration and I catch it. but the hook is really basic, no auth, nothing.

10:15 <cmouse> maybe the api has changed?

10:15 <Guest40> ```c['www']['change_hook_dialects'] = {

10:15 <Guest40>   'github': {

10:15 <Guest40>     'secret': 'p4nterar0z',

10:15 <Guest40>     'strict': True,

10:15 <Guest40>   },

10:15 <Guest40>   'bitbucket': {}

10:15 <Guest40> }```

10:15 <cmouse> i ment on bitbucket side.

10:15 <Guest40> sorry

10:15 <Guest40> yeah, I get it.

10:16 <Guest40> this still doesn't solve my problem. should I file a bug, maybe?

10:17 <cmouse> maybe, yes.

10:21 <Guest40> any guidance on trying to solve this on my own. not sure I have what it takes to get it done but I already have the JSON that bitbucket sent, from their web console. this should match something on the buildbot side that parses it. not sure where to look - any help appreciated.

11:22 <dottedmag> Here's the parsing code: https://github.com/buildbot/buildbot/blob/master/master/buildbot/www/hooks/bitbucket.py#L32

11:47 <cmouse> it also has a useful looking URL as comment

11:58 <Guest40> I mananged to update the code and get it working. I would need some 'adult supervision' to make sure it's all OK. https://pastebin.com/GyztHkyR

12:00 <cmouse> you could maybe simplify a bit =)

12:01 <cmouse> payload = json.loads(content)

12:01 <cmouse> if you are using python 3.6+ you can feed bytes to loads

12:02 <cmouse> also now your code pushes each individual commit as change, did you want this?

12:03 <cmouse> although, well, so did the old one, so never mind

12:03 <cmouse> othar than that, it looks good.

12:03 <cmouse> possibly would be less diff if you don't rename changes => chf

12:03 <Guest40> I have no history as to how this worked before. Only the code. And the only way to extract that kind of data that it *seems* to want, is pushing each individual commit.

12:03 <cmouse> chg

12:05 <cmouse> ah =)

12:05 <cmouse> you have a bug =)

12:05 <cmouse> log.msg(f'Received {len(chg)} changes from bitbucket') should use 'changes' not 'chg'

12:05 <Guest40> there's also the issue of populating revlink and the files, which no longer are present in the json sent by bitbucket.

12:05 <cmouse> as the array which you append stuff into is 'changes'

12:05 <Guest40> ok

12:06 <Guest40> fair enough, updated to reflect that

12:07 <Guest40> so maybe I should just create an issue and a pull request that contains the fix

12:08 <cmouse> that would be nice, yes.

12:10 <Guest40> here comes the actual hard work. :)

12:10 <Guest40> documenting the issue and the fix

12:10 <Guest40> thanks for the help cmouse

12:10 <cmouse> np, thanks for fixing this!