<RP>
tardyp: We have been running with my version which does seem to help a lot (although I didn't make it delay the builds at all so we do get some out of order)
<RP>
tardyp: confirmed your patch also works although 1 second doesn't look like quite long enough on our infrastructure . Needs about 3s I suspect
<tardyp>
so this might mean the events should be sent at once, rather than in between db access
<tardyp>
probably your db is already busy with logs
<tardyp>
grep 'added buildset' twistd.log
<tardyp>
we can see the performance of adding a buildset. On the metabuildbot infra, the perf is about one buildset per second
<tardyp>
well, more 500ms. it takes 12s to trigger 24 builds.
<tardyp>
this is not really expected.
<RP>
tardyp: we only add one buildset which contains many different builderids so the logs don't help and it shouldn't be that
<tardyp>
RP: ah.. you mean there is only one triggerable, which contains several builders in it?
<RP>
tardyp: yes
<tardyp>
metabuildbot configures each build with specific properties, so has multiple buildsets
<RP>
but it seems to take a while to add all the builders (57 of them)
<tardyp>
mmhh, in this case, the codepath is totally different, and the buildrequest events should be sent at the same time.