ChanServ changed the topic of #armlinux to: ARM kernel talk [Upstream kernel, find your vendor forums for questions about their kernels] | https://libera.irclog.whitequark.org/armlinux
djrscally has quit [Ping timeout: 252 seconds]
Pali has quit [Ping timeout: 260 seconds]
XV9 has joined #armlinux
XV8 has quit [Ping timeout: 245 seconds]
shoragan has quit [Ping timeout: 260 seconds]
apritzel_ has quit [Ping timeout: 256 seconds]
shoragan has joined #armlinux
Lucanis0 has quit [Quit: Leaving]
Lucanis has joined #armlinux
Lucanis has quit [Changing host]
Lucanis has joined #armlinux
jlinton has joined #armlinux
amitk has joined #armlinux
jlinton has quit [Ping timeout: 256 seconds]
Lucanis0 has joined #armlinux
Lucanis has quit [Ping timeout: 260 seconds]
Lucanis has joined #armlinux
Lucanis has quit [Changing host]
Lucanis has joined #armlinux
Lucanis0 has quit [Ping timeout: 260 seconds]
cbeznea has joined #armlinux
Xogium has quit [Quit: Leaving.]
Xogium has joined #armlinux
iivanov has joined #armlinux
frieder has joined #armlinux
guillaume_g has joined #armlinux
monstr has joined #armlinux
Peng_Fan has joined #armlinux
<mvaittin>
do we have a 'de-facto' way of handling I2C (MFD) devices with two physical IRQ lines (wired to SoC GPIOs)? (Each flagging multiple IRQs based on the usual status regs).
<mvaittin>
I tried creating two regmap IRQ chips - interrupts seem to work, but this causes a collision in debugfs as it s tries to create same domain file for both domains.
<mvaittin>
Eg, both domains try to create same file under '/sys/kernel/debug/irq/domains'
<mvaittin>
am I doing something that's conceptually wrong - or should there be for example some ID-number appended to the domain files if more than one domain is created(?)
milkylainen has joined #armlinux
headless has joined #armlinux
djrscally has joined #armlinux
sszy has joined #armlinux
kos_tom has quit [Ping timeout: 256 seconds]
luispm has joined #armlinux
mcoquelin has quit [Remote host closed the connection]
Pali has joined #armlinux
prabhakarlad has joined #armlinux
mcoquelin has joined #armlinux
alexels has joined #armlinux
Pali has quit [Ping timeout: 252 seconds]
kos_tom has joined #armlinux
matthias_bgg has joined #armlinux
Misotauros has quit [Ping timeout: 260 seconds]
<geertu>
mvaittin: Unique naming is an issue that pops up regularly, when you have two instances of the same device.
<mvaittin>
geertu: hmm... in this case the file-name seems to contain full DT path - which means it should be unique for two different devices of same type. (If this is what you meant). But in this case the same device would have two IRQ domains. Anyways, if this is a common issue - then there is some common convention to deal with it, right?
<mvaittin>
Or people just ignore the error and live with the missing debugfs entries?
<geertu>
mvaittin: Oh, it's a single device. Where does it take the name from? From the parent device, I guess?
<geertu>
lag: ^
<geertu>
maz: ^
<mvaittin>
geertu: The device node which contains the IRQ.
<mvaittin>
in this case IRQs
<geertu>
broonie: ^
<geertu>
(now we have all of mfd, irq, and regmap at the party, I think ;-)
* mvaittin
wonders if it would be good idea to append an ID to debugfs domain name when multiple IRQs are specified in DT(?) Does that always mean there should be own domain for each IRQ?
<mvaittin>
geertu: Thanks :)
headless has quit [Quit: Konversation terminated!]
Misotauros has joined #armlinux
<geertu>
arnd: Time to update the "ARM" prefix in "ARM: SoC updates for 5.18"? The PolarFire is RISC-V, until someone creates an ARM core inside its FPGA ;-)
<arnd>
geertu: good point. I've been a bit inconsistent about it, and I think I previously used 'soc:' as a prefix when I had non-arm stuff in there, but forgot about it this time
<lag>
geertu: mvaittin: Since MFDs are usually platform devices, we usually solve this with platform IDs
<lag>
And yes, off the top of my head, I would think each instance would have it's own IRQ Domain (usually registered in .probe()
<lag>
Caveat: This is all off the top of my head - do you have a specific example you're trying to work through?
<mvaittin>
lag: Well, situation here is that one instance has two domains.
<lag>
mvaittin: By design or as an unfortunate side-effect?
<mvaittin>
The IC has two physical IRQ lines by design.
<mvaittin>
the reason for such HW-design has not been explained to me though :)
<lag>
mvaittin: Not sure how the MFD API would handle that (the IRQ domain ptr is usually provided as part of the mfd_add_devices() call) - I guess you'd have to create them manually in your driver
<mvaittin>
lag: What I did is resolving the IRQ offsets in MFD and passing NULL to the MFD sub-device registration API. It works, but the two domains for one instance causes a collision in IRQ domain debugfs file-name
<lag>
domain = irq_find_host(parent->of_node);
<lag>
We expect 1 domain per device
<lag>
mvaittin: Sounds like maz's "domain"
<mvaittin>
lag: yes. Hence I asked if I am doing something which is conceptually wrong - and if there is a 'de-facto' way of handling the situation where one device provides multuple IRQ lines :) (I believe there is as it does not sound too exotic to me)
<lag>
mvaittin: Right, the MFD only provides helpers for one domain, but there is nothing stopping you adding 2 manually
<lag>
As for the naming clashes, you'd have to take a look at the IRQ Domain API
<mvaittin>
lag: Thanks :)
* mvaittin
goes digging the domain API then
apritzel has joined #armlinux
<lag>
mvaittin: Take a look at irq_domain_update_bus_token() -- does that help you?
<mvaittin>
lag: Thanks! The irq_domain_update_bus_token() seems to be doing exactly what would be needed. How it fits to the regmap_irq domain registration is still somewhat unclear to me though ;) I need to try reading the code so I get better picture of this.
headless has joined #armlinux
<maz>
the bus token is there when mujltiple devices are attached to a device, but represent different 'functions' of that device.
<maz>
I'm not sure this is the case here, but just saying in passing ;-)
<maz>
in general, they are more a function of the bus they are atttached to rather than the device itself.
<maz>
(hence the name).
<mvaittin>
maz: Thanks. I noticed that too when taking a look at the bus_token enum values. I can't help thinking that I am missing something obvious... :)
Norkle has quit [Ping timeout: 240 seconds]
torez has joined #armlinux
Norkle has joined #armlinux
headless has quit [Quit: Konversation terminated!]
<mvaittin>
hmm. The irq_domain_update_bus_token() would really solve the naming clash w/o changing anything in regmap_irq or MFD. I feel using it is a bit off - but I guess the draft version lives with that :) Thanks again all.
Lucanis has quit [Quit: Leaving]
Lucanis has joined #armlinux
Lucanis has quit [Changing host]
Lucanis has joined #armlinux
Lucanis has quit [Remote host closed the connection]
Lucanis has joined #armlinux
Lucanis has joined #armlinux
Lucanis has quit [Changing host]
SallyAhaj has quit [Remote host closed the connection]
Lucanis has quit [Remote host closed the connection]
Lucanis has joined #armlinux
Lucanis has joined #armlinux
aposm_ is now known as aposm
jlinton has joined #armlinux
SallyAhaj has joined #armlinux
amitk has quit [Ping timeout: 260 seconds]
amitk has joined #armlinux
amitk has quit [Ping timeout: 240 seconds]
amitk has joined #armlinux
prabhakarlad has quit [Quit: Client closed]
sudeepholla has quit [Ping timeout: 256 seconds]
cbeznea1 has joined #armlinux
cbeznea has quit [Read error: Connection reset by peer]
Tokamak has quit [Ping timeout: 240 seconds]
sudeepholla has joined #armlinux
Tokamak has joined #armlinux
XV9 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
prabhakarlad has joined #armlinux
XV8 has joined #armlinux
headless has joined #armlinux
frieder has quit [Remote host closed the connection]
SallyAhaj has quit [Remote host closed the connection]
jlinton has quit [Quit: Client closed]
jlinton has joined #armlinux
Amit_T has joined #armlinux
guillaume_g has quit [Quit: Konversation terminated!]
<arnd>
robher: as long as we still allow running on seattle, I think it makes sense to keep the dts, if only to make it easier to look stuff up. If you mean removing seattle support altogether, that would have some nice benefits but it might still be too early
<arnd>
robher: torvalds just merged all I had queued yesterday, so I merged the series into the fixes branch and pushed that out as the new for-next
<arnd>
I'll wait what other fixes come up, plan to send it all beginning of next week then
<robher>
arnd: removing DT support and leaving ACPI support is what I meant. I'm told ACPI actually worked (compared to XGene).
<arnd>
ok
<robher>
arnd: At some point we're have to say seattle needs schema files and warnings fixed or drop it.
<arnd>
fair enough
XV8 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
XV8 has joined #armlinux
Misotauros has quit [Ping timeout: 272 seconds]
Misotauros has joined #armlinux
Tokamak_ has quit [Ping timeout: 240 seconds]
Tokamak has joined #armlinux
Amit_T has quit [Ping timeout: 240 seconds]
prabhakarlad has quit [Quit: Client closed]
jlinton has quit [Quit: Client closed]
SallyAhaj has joined #armlinux
prabhakarlad has joined #armlinux
SallyAhaj has quit [Read error: Connection reset by peer]
SallyAhaj has joined #armlinux
prabhakarlad has quit [Quit: Client closed]
headless has quit [Ping timeout: 260 seconds]
headless has joined #armlinux
nsaenz has quit [Remote host closed the connection]
headless has quit [Quit: Konversation terminated!]
jlinton has joined #armlinux
cbeznea1 has quit [Ping timeout: 252 seconds]
SallyAhaj has quit [Remote host closed the connection]
SallyAhaj has joined #armlinux
SallyAhaj has quit [Remote host closed the connection]
SallyAhaj has joined #armlinux
SallyAhaj has quit [Quit: Leaving]
iivanov has quit [Remote host closed the connection]
SallyAhaj has joined #armlinux
matthias_bgg has joined #armlinux
SallyAhaj has quit [Remote host closed the connection]
SallyAhaj has joined #armlinux
archetech has quit [Quit: Konversation terminated!]